I noticed that sometimes, my customers and I mistakenly put some triggers after an unconditional transition (e.g. when copy-pasting a trigger). In such a situation, the trigger is of course never executed.
If we are in a hurry or not focused, and/or if triggers are not well named, we can easily forget this and not understand why trigger(s) after the transition don’t execute.
I think it would be great if a warning icon was shown if one or several triggers find themselves after an unconditional transition trigger in a list.
Thanks @fti and @danielpomeranz for the suggestion. We’re thinking about Trigger Errors and App validation in general, so we’ll add this to the broad list of requests there.
The first step we’re investigating taking is surfacing errors e.g. in Connector Functions on App Publish. Validation, warnings, and other best practice recommendations could be a valuable next step but could become increasingly tricky to detect.
You mentioned good Trigger naming – do you think having block comments could help?
@OlgaStroilova Obviously it would be nice, but I generally advocate for “clean code” Tulip to avoid lengthy triggers with many blocks. It is almost always cleaner to separate things out. I worry that if someone needs to add comments to each block of their triggers than they are doing too much.
@OlgaStroilova Adding comments is a possibility but I already find the current trigger editing GUI cumbersome and hard to read. So to me, adding comments would worsen the situation unless the GUI is improved.
Currently we have trigger descriptions which is a good thing to have and use. It should be enough if on top of that we separate triggers neatly as described by @danielpomeranz.
Let’s see how many votes this suggestion gets and what other people have to say? Maybe there aren’t enough users bothered by this to justify the development effort.
